Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Sort out expected-failures for share expiration date #2412

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 17, 2021

Description

The related issue is "Implement expiration date for shares"

The scenarios related to that issue had ended up in a couple of different places. This PR puts the scenarios together in the expected-failures file in 3 sections, for user, group and public link shares. This should make it easier when a developer starts to implement this some day.

And bump the core commit id.

Related Issue

#1250

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Aug 17, 2021
@phil-davis phil-davis changed the title [tests-only] Sort out expected-failures for share expiration date [full-ci] [tests-only] Sort out expected-failures for share expiration date Aug 17, 2021
@phil-davis phil-davis force-pushed the adjust-expected-failures-1250 branch from f7fb6c5 to 1e8ebbe Compare August 17, 2021 16:15
@phil-davis
Copy link
Contributor Author

Note: owncloud/core#39120 will stop the lock breaker groups scenarios from running in oCIS CI. I will bump the commit id after that is merged to core master.

@phil-davis phil-davis force-pushed the adjust-expected-failures-1250 branch from 1e8ebbe to d0de8f3 Compare August 18, 2021 03:26
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 42e1903 into master Aug 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjust-expected-failures-1250 branch August 18, 2021 05:44
ownclouders pushed a commit that referenced this pull request Aug 18, 2021
Merge: 3c0ce61 5d7064a
Author: Phil Davis <[email protected]>
Date:   Wed Aug 18 11:29:54 2021 +0545

    Merge pull request #2412 from owncloud/adjust-expected-failures-1250

    [full-ci] [tests-only] Sort out expected-failures for share expiration date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants